Skip to contentSkip to conversation

Change in openvpn[master]: Haiku: change del to delete in route command. del is undocumented

Openvpn-devel In review kallisti5 (Code Review) 3 participants 7 messages Jan 28, 2025 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1738029022000.Ieca0f8aa07413682d39e73dd3ed21a0038d41f49@...2715...

#1 lore raw

Attention is currently required from: flichtenheld, plaisthos.

Hello plaisthos, flichtenheld,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/690?usp=email

to review the following change.

Change subject: Haiku: change del to delete in route command. del is undocumented
......................................................................

Haiku: change del to delete in route command. del is undocumented

Change-Id: Ieca0f8aa07413682d39e73dd3ed21a0038d41f49
---
M src/openvpn/route.c

1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/690/1

src/openvpn/route.c +4 -4
index d17b285..12d6c07 100644
@@ -2359,8 +2359,8 @@
 
 #elif defined(TARGET_HAIKU)
 
-    /* ex: route del /dev/net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.1 netmask 255.255.0.0 */
-    argv_printf(&argv, "%s del %s inet %s gw %s netmask %s",
+    /* ex: route delete /dev/net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.1 netmask 255.255.0.0 */
+    argv_printf(&argv, "%s delete %s inet %s gw %s netmask %s",
                 ROUTE_PATH,
                 rgi->iface,
                 network,
@@ -2551,8 +2551,8 @@
         "on connect only and will clean up automatically.");
 #elif defined(TARGET_HAIKU)
 
-    /* ex: route del /dev/net/ipro1000/0 inet6 :: gw beef::cafe prefixlen 64 */
-    argv_printf(&argv, "%s del %s inet6 %s gw %s prefixlen %d",
+    /* ex: route delete /dev/net/ipro1000/0 inet6 :: gw beef::cafe prefixlen 64 */
+    argv_printf(&argv, "%s delete %s inet6 %s gw %s prefixlen %d",
                 ROUTE_PATH,
                 r6->iface,
                 network,

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/690?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ieca0f8aa07413682d39e73dd3ed21a0038d41f49
Gerrit-Change-Number: 690
Gerrit-PatchSet: 1
Gerrit-Owner: kallisti5 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-MessageType: newchange

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld, plaisthos.

kallisti5 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/690?usp=email )

Change subject: Haiku: change del to delete in route command. del is undocumented
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:
Just noticed that while "del" works, we document "delete". Just wanted to address future compatibility issues.

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/690?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ieca0f8aa07413682d39e73dd3ed21a0038d41f49
Gerrit-Change-Number: 690
Gerrit-PatchSet: 1
Gerrit-Owner: kallisti5 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Tue, 28 Jan 2025 01:52:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

#3 lore raw
In reply to a message not in the archive

Attention is currently required from: kallisti5, plaisthos.

flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/690?usp=email )

Change subject: Haiku: change del to delete in route command. del is undocumented
......................................................................

Patch Set 1: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/690?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ieca0f8aa07413682d39e73dd3ed21a0038d41f49
Gerrit-Change-Number: 690
Gerrit-PatchSet: 1
Gerrit-Owner: kallisti5 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: kallisti5 <[email protected]...>
Gerrit-Comment-Date: Tue, 28 Jan 2025 12:38:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

#4 lore raw

PATCH 1/1 Haiku: change del to delete in route command. del is undocumented

In reply to a message not in the archive

From: Alexander von Gluck <[email protected]...>

Change-Id Ieca0f8aa07413682d39e73dd3ed21a0038d41f49

---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/690
This mail reflects revision 1 of this Change.

Signed-off-by line for the author was added as per our policy.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <[email protected]...>

src/openvpn/route.c +4 -4
index d17b285..12d6c07 100644
@@ -2359,8 +2359,8 @@
 
 #elif defined(TARGET_HAIKU)
 
-    /* ex: route del /dev/net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.1 netmask 255.255.0.0 */
-    argv_printf(&argv, "%s del %s inet %s gw %s netmask %s",
+    /* ex: route delete /dev/net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.1 netmask 255.255.0.0 */
+    argv_printf(&argv, "%s delete %s inet %s gw %s netmask %s",
                 ROUTE_PATH,
                 rgi->iface,
                 network,
@@ -2551,8 +2551,8 @@
         "on connect only and will clean up automatically.");
 #elif defined(TARGET_HAIKU)
 
-    /* ex: route del /dev/net/ipro1000/0 inet6 :: gw beef::cafe prefixlen 64 */
-    argv_printf(&argv, "%s del %s inet6 %s gw %s prefixlen %d",
+    /* ex: route delete /dev/net/ipro1000/0 inet6 :: gw beef::cafe prefixlen 64 */
+    argv_printf(&argv, "%s delete %s inet6 %s gw %s prefixlen %d",
                 ROUTE_PATH,
                 r6->iface,
                 network,
#5 lore raw

[Openvpn-devel] [PATCH applied] Re: Haiku: change del to delete in route command. del is undocumented

Not much to test here :-) - patch only affects #ifdef TARGET_HAIKU blocks and only "route" command line naming.

Your patch has been applied to the master branch.

commit 625b3e91b9a5b3283ae59cdab253a55e34feea7f

Author: Alexander von Gluck
Date:   Tue Jan 28 13:41:29 2025 +0100
     Haiku: change del to delete in route command. del is undocumented

     Signed-off-by: Alexander von Gluck <[email protected]...>
     Acked-by: Frank Lichtenheld <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg30655.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#6 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#2) to the change originally created by kallisti5. ( http://gerrit.openvpn.net/c/openvpn/+/690?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by flichtenheld

Change subject: Haiku: change del to delete in route command. del is undocumented
......................................................................

Haiku: change del to delete in route command. del is undocumented

Change-Id Ieca0f8aa07413682d39e73dd3ed21a0038d41f49

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg30655.html

---
M src/openvpn/route.c

1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/690/2

src/openvpn/route.c +4 -4
index d17b285..12d6c07 100644
@@ -2359,8 +2359,8 @@
 
 #elif defined(TARGET_HAIKU)
 
-    /* ex: route del /dev/net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.1 netmask 255.255.0.0 */
-    argv_printf(&argv, "%s del %s inet %s gw %s netmask %s",
+    /* ex: route delete /dev/net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.1 netmask 255.255.0.0 */
+    argv_printf(&argv, "%s delete %s inet %s gw %s netmask %s",
                 ROUTE_PATH,
                 rgi->iface,
                 network,
@@ -2551,8 +2551,8 @@
         "on connect only and will clean up automatically.");
 #elif defined(TARGET_HAIKU)
 
-    /* ex: route del /dev/net/ipro1000/0 inet6 :: gw beef::cafe prefixlen 64 */
-    argv_printf(&argv, "%s del %s inet6 %s gw %s prefixlen %d",
+    /* ex: route delete /dev/net/ipro1000/0 inet6 :: gw beef::cafe prefixlen 64 */
+    argv_printf(&argv, "%s delete %s inet6 %s gw %s prefixlen %d",
                 ROUTE_PATH,
                 r6->iface,
                 network,

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/690?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ieca0f8aa07413682d39e73dd3ed21a0038d41f49
Gerrit-Change-Number: 690
Gerrit-PatchSet: 2
Gerrit-Owner: kallisti5 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset

#7 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/690?usp=email )

Change subject: Haiku: change del to delete in route command. del is undocumented
......................................................................

Haiku: change del to delete in route command. del is undocumented

Change-Id Ieca0f8aa07413682d39e73dd3ed21a0038d41f49

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg30655.html

---
M src/openvpn/route.c

1 file changed, 4 insertions(+), 4 deletions(-)
src/openvpn/route.c +4 -4
index d17b285..12d6c07 100644
@@ -2359,8 +2359,8 @@
 
 #elif defined(TARGET_HAIKU)
 
-    /* ex: route del /dev/net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.1 netmask 255.255.0.0 */
-    argv_printf(&argv, "%s del %s inet %s gw %s netmask %s",
+    /* ex: route delete /dev/net/ipro1000/0 inet 192.168.0.0 gw 192.168.1.1 netmask 255.255.0.0 */
+    argv_printf(&argv, "%s delete %s inet %s gw %s netmask %s",
                 ROUTE_PATH,
                 rgi->iface,
                 network,
@@ -2551,8 +2551,8 @@
         "on connect only and will clean up automatically.");
 #elif defined(TARGET_HAIKU)
 
-    /* ex: route del /dev/net/ipro1000/0 inet6 :: gw beef::cafe prefixlen 64 */
-    argv_printf(&argv, "%s del %s inet6 %s gw %s prefixlen %d",
+    /* ex: route delete /dev/net/ipro1000/0 inet6 :: gw beef::cafe prefixlen 64 */
+    argv_printf(&argv, "%s delete %s inet6 %s gw %s prefixlen %d",
                 ROUTE_PATH,
                 r6->iface,
                 network,

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/690?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ieca0f8aa07413682d39e73dd3ed21a0038d41f49
Gerrit-Change-Number: 690
Gerrit-PatchSet: 2
Gerrit-Owner: kallisti5 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged